Closed
Bug 1247878
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Resource leak] In function ensureDatabaseIsNotLocked
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Firefox for Android Graveyard
Data Providers
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 119594 )
Attachments
(1 file)
|
58 bytes,
text/x-review-board-request
|
Details |
The Static Analysis tool Coverity added a memory leak occurs on variable db, we should close it before exiting it's context.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34743/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34743/
Attachment #8718763 -
Flags: review?(mark.finkle)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked. r?mfinkle
Passing to Mike. He's a better reviewer for this.
Attachment #8718763 -
Flags: review?(mark.finkle) → review?(michael.l.comella)
Comment on attachment 8718763 [details]
MozReview Request: Bug 1247878 - close db when exiting ensureDatabaseIsNotLocked. r?mfinkle
https://reviewboard.mozilla.org/r/34743/#review31793
This was discussed and decided to be intentional in bug 1246839 (see https://bugzilla.mozilla.org/show_bug.cgi?id=1246839#c13). I updated the issue in Coverity – are you able to see that?
Attachment #8718763 -
Flags: review?(michael.l.comella)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Blocks: fennec-coverity
|
|
Assignee | |
Comment 4•9 years ago
|
||
Thanks Michael for letting me know. Yes i haev access to Coverity so i can see it.
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•